Bug 6485

Menu icons using PNGs are missing in deployed application 10 May, 2021

Constantin Bergatt
26 April, 2021
Product: PowerBuilder Category: Controls & UI
Version: 2019 R3 Build: 2703
Classification: Appeon bug Publishing: Public
Priority: P2
Status: Scheduling Reason:
Communication Status: Waiting for Appeon
Mark Lee @Appeon 10 May, 2021
#18
Hello Constantin,

Thanks for your confirmation. I will compare the fix with the previous version and let you know the results later.
Appreciate your understanding.

Regards,
Mark Lee
Constantin Bergatt 10 May, 2021
#17
Screenshot.png (30KB)

Hello Mark,

I am very sorry for the late reply!

Today I was able to do some tests with the changed runtime libraries provided.

I can confirm, that the PNG icons are now visible in the deployed application.

BUT they do look a little "coarse-grained" in comparisson to their toolbar icon counterparts.

To be honest we switched to using PNG files in order for the menu icons to look much better, sharper, etc. and with this change they look again like their PNG predecessors.

Any chance that the quality of the shown PNG files can be improved?

Best regards,
Constantin Bergatt
Mark Lee @Appeon 07 May, 2021
#16
Runtime 19.2.0.2703 for Menu

Hi Miguel & Constantin,

Our developer has fixed the issue in the codebase.
Please replaces the PBVM.DLL and PBSHR.DLL (default directory is: C:\Program Files (x86)\Appeon\Common\PowerBuilder\Runtime 19.2.0.2703) with this attached one.
Please back up your old files before replacing them.
After that please restart the computer and see if it works on your side.
 
BTW, we haven't fully tested this fix yet, so we suggest that you do some more Menu functionality-related tests to verify if there are other issues. 
Thanks!

Regards,
Mark Lee
Miguel Leeuwe 05 May, 2021
#15
Thank you Mark and Constantin.
Miguel Leeuwe 05 May, 2021
#14
FWIW:
Same problem here. I've just had to list all png files used in our menus and rebuild all my installers to now distribute the PNGs to be included in the folder of the executable files.
regards.
Mark Lee @Appeon 05 May, 2021
#13
Hi Miguel & Constantin,
 
Thanks for your feedback. 
If everything goes well, we will try to provide a temp DLL file for you to verify this issue ASAP.
Appreciate your patience and understanding.
 
 
Best regards,
Mark Lee
Constantin Bergatt 05 May, 2021
#12
Hi Miguel,

I still hope, that Appeon can provide us with a fix before our next release. Let's keep the fingers crossed.

Good luck with your release!

Regards,
Constantin
Miguel Leeuwe 04 May, 2021
#11
I totally agree with you, but we are in the middle of a release, so for me there's no other choice. Once Appeon fixes it (hopefully without breaking something else), I'll take them out of the installers again.
regards.
Constantin Bergatt 04 May, 2021
#10
Hi Miguel,

many thanks for your feedback!

Unfortunately due to having a very complex application, I would have to ship about 1200 PNG files together with our application. Besides "cluttering" the already fully packed application folder even more, it would also make the task for our installer even harder (handling images, setting access rights to stop the user from meddling with the icons, etc. ) and add another error source (corrupted or accidentily removed files) to our program.

Therefore I would much appreciate, if I can avoid the shipping of the icons together with the binaries at all costs.

Regards,
Constantin
Mark Lee @Appeon 04 May, 2021
#9
Hi Miguel,

Thanks for your feedback.
We will transfer it to our development team for consideration.

Regards,
Mark Lee
Miguel Leeuwe 04 May, 2021
#8
FWIW:
Same problem here. I've just had to list all png files used in our menus and rebuild all my installers to now distribute the PNGs to be included in the folder of the executable files.
regards.
Mark Lee @Appeon 29 April, 2021
#7
Hi Constantin,

OK, no problem. We will keep you updated!

Regards,
Mark Lee
Constantin Bergatt 29 April, 2021
#6
Hi Mark,

thanks a lot for the reply!

Then I'll wait for your status updates.

Please let me know, if there is anythin I can help you with!

Regards,
Constantin
Mark Lee @Appeon 28 April, 2021
#5
Hi Constantin,

Thanks for confirming that the DLL fixes the current issue.
Sorry for the convenient caused. We understand that rolling back ticket 5837 is unacceptable. No matter whether it is ticket 5837 or 6485, we actively promote them so that they could be fixed in time.
 
Our development team will continue analyzing ticket 5837, however, since it is more complicated than we thought, and there are also other customers reporting issues similar to this one, we need to deal with it carefully so we can't give you an estimate date for now. But we will try our best and I will keep you posted on the progress. 

Thanks for your understanding.

Regards,
Mark Lee
Constantin Bergatt 27 April, 2021
#4
Hi Mark,

thanks for the quick update!

As instructed, I've replaced the installed PBVM.DLLs with the new ones and can confirm, that the icons are visible again.

Unfortunately at the price of losing the solution to Bug 5837, which is not acceptable to us. Because this issue has severe impact on our user experience. It is hard to explain to our users, why some icons do look different (white non-transparent background) to all the others.
And I do not agree, that the issue can be ignored, when the theme is turned on. When the user does hover over the separate menu icons, there is a very huge difference moving from an icon with transparent background and than coming to an icon with a white, non-transparent "block" around it. It does disturb the overall impression very much.
Further as we leave it to our customers to use the theme or not due to performance reasons, we cannot always assume a theme being used. Which overall further contributes to the deterioration of the overall impression.

Can you give us a rough estimate if and when this issue will be tackled? As we are working towards a new release, we would pretty much like to know, if it is feasible to wait for your solution to this problem or simply do a total backflip and not use "PowerBuilde 2019 R3 Build 2703".

Regards,
Constantin
Mark Lee @Appeon 27 April, 2021
#3
new PBVM.DLL

Hi Constantin,

Sorry to let you know that we still can't find out a better workaround for this issue, so we decided to roll back the fix of ticket 5837 temporarily and provide a new DLL for you to verify this issue.
I verified using the new case you provided and found that if the Theme functionality is enabled, the issue in ticket 5837 can be ignored.
 
Please replace the PBVM.DLL (default directory is: C:\Program Files (x86)\Appeon\Common\PowerBuilder\Runtime 19.2.0.2703) with this attached one.
Please back up your old file before replacing them.
After that please restart the computer and see if it works on your side.
 
BTW, we haven't fully tested this fix yet, so we suggest that you do some more Menu functionality-related tests to verify if there are other issues. 
Thanks!

Regards,
Mark Lee
Mark Lee @Appeon 26 April, 2021
#2
Hi Constantin,

Thanks for reporting this problem and providing the test case.
We can reproduce this issue on our side. I discussed with the development team and found that this issue is caused by the fix to ticket 5837.
 
We still can't find out a better workaround for it at present according to the current analysis results, if we still can't address this issue then we might need to roll back that fix and will provide a new DLL based on PB 2019 R3 2703 for you to verify this issue.
 

Best regards,
Mark Lee
Constantin Bergatt 26 April, 2021
#1
testapp (Version 1).7z (352KB)

*Phenomenon:
While restesting some of our open issues with the new "PowerBuilder 2019 R3 Build 2703" maintenance release, it was found, that all menu icons using PNGs are missing in the deployed application, when the referenced PNGs are no longer available.

*Reproduce Steps:
You can find a respective test application attached to this bug (see testapp (Version 1).7z).

In the provided test application archive you will find the following :
- "Bins" folder : The deployed bins moved to the "Bins" subfolder in order to invalidate the used relative pathes to the menu icons.
- "Icons" folder :  The used PNG files.
- "Screenshots" folder : Some explanatory screenshots.
- "theme" folder : The used UI theme definition.

1. Create a small test application with a very simple window, which does have a menu.
2. Add a menu item.
3. Assign an icon with a transparent background to the menu item, e.g. "Icons\Invoice.png" from the test application.
4. Add the assigned icon to the PBR file of your test application.
5. Deploy the application.
6. Move the resulting bins and the "theme" folder to a place where the resource paths are no longer valid.
10. Run the application.

Result : The menu icon is not visible at all.
Expected : The menu icon should be visible.

Hint : For my test application I used relative paths to the assigned icons. Therefore I moved the created binaries as well as the "theme" folder to the subfolder "Bins" in order to "cut the links" from the ressources to the binaries. Please check the provided binaries for your own tests.

Remarks:
This issue is a real problem for us, as we just did a huge icon refurbishment and converted all our icons to PNGs. With the new version all of our icons are missing, meaning all of our efforts are wasted!
Any help on this topic is much appreciated!!!
OS:
Windows 10
Platform:
All
Database Type:
SAP SQL Anywhere
Database Version:
17.0.10.6175