Bug 4938

SVN with needs-lock property and edit objects without Get Lock first 14 January, 2021

Julián Tagarro
12 July, 2020
Product: PowerBuilder Category: PowerBuilder IDE
Version: 2019 R2 Build: 2328
Classification: Enhancement Publishing: Public
Priority: P3
Status: Closed Reason: RECORDED AS ENHANCEMENT
Appeon Product 14 January, 2021
#6
Hi Julián,  

 

Thank you for submitting the ticket.  

We now acknowledge this ticket to be an enhancement request and will record and track it internally in our enhancement management system. At the same time, we are closing the ticket here because this support system is for handling standard support services but not for maintaining enhancement requests.  

Please note that despite its "Closed" status, you are welcome to come back here and leave further comments or query the relevant development progress on this ticket.  

 

Regards,  

Amy Feng
Julián Tagarro 14 July, 2020
#5
(In reply to Tom Jiang @Appeon from comment #4)
Julián,

I agree with you that preventing the changes to be saved in the PBL may be a
better option. I am passing this ticket as an enhancement request to our
product team to consider in a future release. 

Thanks again for your valuable suggestion!

Regards,

Tom Jiang
Hi Tom, Thanks for your answer. It should work just as it works with MSSCCI. Just disable the Save option if the object is not locked and needs-lock option is set. Again, respectfuly, this issue and the one posted in #4943 are very basic UI feature. They should be enhanced as soon as possible. Regards, Julián Tagarro.
Tom Jiang @Appeon 14 July, 2020
#4
Julián,

I agree with you that preventing the changes to be saved in the PBL may be a better option. I am passing this ticket as an enhancement request to our product team to consider in a future release. 

Thanks again for your valuable suggestion!

Regards,

Tom Jiang
Julián Tagarro 13 July, 2020
#3
(In reply to Tom Jiang @Appeon from comment #2)
Hi Julián,

When an object has the need-lock property set, you will not be able to save
the object (export the source code for the object to the ws_objects folder)
without getting a lock first. 

The reason that you see the changes in PB IDE is that the PBL doesn't have
the need-lock property set, so the changes are saved in the PBL. 

If you do a refresh on the object, it will imports the object in the
ws_objects folder and the changes in PB IDE should revert to the original
code. 

So for your issue, we suggest that you always get the lock before editing
any objects or remove the need-lock property if it doesn't fit in your
workflow. 

Regards,

Tom Jiang
Hi Tom. I can see that the "refresh" option does retrieve the original version from ws_objects. Still, I think that PB should detect this situation and prevent the changes to be saved in the PBL. It could be a very useful enhancement. Regards. Julián Tagarro.
Tom Jiang @Appeon 13 July, 2020
#2
Hi Julián,

When an object has the need-lock property set, you will not be able to save the object (export the source code for the object to the ws_objects folder) without getting a lock first. 

The reason that you see the changes in PB IDE is that the PBL doesn't have the need-lock property set, so the changes are saved in the PBL. 

If you do a refresh on the object, it will imports the object in the ws_objects folder and the changes in PB IDE should revert to the original code. 

So for your issue, we suggest that you always get the lock before editing any objects or remove the need-lock property if it doesn't fit in your workflow. 

Regards,

Tom Jiang
Julián Tagarro 12 July, 2020
#1
snv_without_getlock_PB2019.jpg (19KB)

*Phenomenon:

If I try to modify an object (add a commandbutton to a window for example) without locking it with "SVN Get Lock", PowerBuilder saves the change into the object but shows the attached (acurate by the way) message.

So, I have the object modified into the PBL but without the possibility to upload it to the repository. 

What am I missing ?

*Reproduce Steps:

In a workspace uploaded with SVN + needs-lock configured, open any object without locking it, modify it and then save it. The object is saved into the PBL but not marked for SVN Update into the repository.

Remarks:
OS:
Windows 10
Platform:
64-bit
Database Type:
Microsoft SQL Server
Database Version:
2008